Re: [igt-dev] [PATCH i-g-t 07/17] tests/kms_addfb_basic: Add invalid buffer object test for discrete
From: Petri Latvala <hidden>
Date: 2021-06-11 11:38:58
On Fri, Jun 11, 2021 at 10:49:55AM +0530, venkata.sai.patnana@intel.com wrote:
quoted hunk ↗ jump to hunk
From: Mohammed Khajapasha <redacted> Add invalid buffer object test case for discrete, to validate IOCTL_MODE_ADDFB2 ioctl for LMEM, the framebuffer backing gem objects should be from local memory for discrete. Cc: Latvala Petri <redacted> Cc: Michael J. Ruhl <redacted> Signed-off-by: Mohammed Khajapasha <redacted> Acked-by: Michael J. Ruhl <redacted> --- tests/kms_addfb_basic.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c index 1fb18d668f..a67a12c97e 100644 --- a/tests/kms_addfb_basic.c +++ b/tests/kms_addfb_basic.c@@ -40,6 +40,7 @@ #include "igt_rand.h" #include "igt_device.h" +#include "i915/intel_memory_region.h" uint32_t gem_bo; uint32_t gem_bo_small;@@ -146,6 +147,22 @@ static void invalid_tests(int fd) igt_assert(f.modifier[0] == 0); } + igt_describe("Check if addfb2 call works for LMEM");
Shouldn't this rather be "Check that addfb2 with a system memory gem object fails correctly if device requires local memory framebuffers" or something along those lines, right? -- Petri Latvala
+ igt_subtest("invalid-smem-bo-on-discrete") {
+ int devid;
+ uint32_t handle, stride;
+ uint64_t size;
+
+ igt_require_intel(fd);
+ devid = intel_get_drm_devid(fd);
+ igt_require(gem_has_lmem(devid));
+ igt_calc_fb_size(fd, f.width, f.height,
+ DRM_FORMAT_XRGB8888, 0, &size, &stride);
+ handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
+ f.handles[0] = handle;
+ do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f, EREMOTE);
+ }
+
igt_describe("Check if addfb2 call works for legacy formats");
igt_subtest("legacy-format") {
struct {
--
2.25.1_______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev