Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_ccs: Skip CCS color clear value check for randomizing subtests
From: Rodrigo Siqueira <hidden>
Date: 2021-05-05 00:23:09
Hi, I looked at kms_ccs and tried to find a reference for "color control surfaces" in DRM, and I found multiple references for this format in i915. Is it an Intel-specific format? Is kms_ccs a test that can be executed in different ASICs? Thanks Siqueira On 04/29, Imre Deak wrote:
quoted hunk ↗ jump to hunk
When filling the color planes with randomized content, the color clear values won't match what the HW actually wrote there, so skip the clear value check in this case. Cc: Juha-Pekka Heikkila <redacted> Cc: Mika Kahola <redacted> Cc: Ville Syrjälä <redacted> Signed-off-by: Imre Deak <redacted> --- tests/kms_ccs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c index 30e0fdb54..61c9b2277 100644 --- a/tests/kms_ccs.c +++ b/tests/kms_ccs.c@@ -195,7 +195,7 @@ static void check_ccs_cc_plane(int drm_fd, igt_fb_t *fb, int plane, const float munmap(map, fb->size); }; -static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color) +static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color, bool check_cc_plane) { int i;@@ -203,7 +203,7 @@ static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color if (igt_fb_is_ccs_plane(fb, i) && !igt_fb_is_gen12_ccs_cc_plane(fb, i)) check_ccs_plane(drm_fd, fb, i); - else if (igt_fb_is_gen12_ccs_cc_plane(fb, i)) + else if (igt_fb_is_gen12_ccs_cc_plane(fb, i) && check_cc_plane) check_ccs_cc_plane(drm_fd, fb, i, cc_color); } }@@ -348,7 +348,7 @@ static void generate_fb(data_t *data, struct igt_fb *fb, igt_assert_eq(ret, 0); if (check_ccs_planes) - check_all_ccs_planes(data->drm_fd, fb, cc_color); + check_all_ccs_planes(data->drm_fd, fb, cc_color, !(data->flags & TEST_RANDOM)); fb->fb_id = f.fb_id; }-- 2.27.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Figt-dev&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C015d075eda3348bce83208d90b44b52e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553211995281967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=IqMSw%2BtvmobHEOTGjdcrUL%2BE3gW6QlRfavthnqM1%2FVc%3D&reserved=0
-- Rodrigo Siqueira https://siqueira.tech