Re: [igt-dev] [i-g-t] tests/i915/perf: Added check for testcase to get discarded on less than gen12 platform

On Thu, Mar 25, 2021 at 07:00:23PM +0200, Ram Moon, AnandX wrote:

Hi Petri,

-----Original Message-----
From: Latvala, Petri <redacted>
Sent: Thursday, March 25, 2021 4:17 PM
To: Ram Moon, AnandX <redacted>
Cc: igt-dev@lists.freedesktop.org; Landwerlin, Lionel G <redacted>; Nerlige Ramappa, Umesh <redacted>
Subject: Re: [igt-dev] [i-g-t] tests/i915/perf: Added check for testcase to get discarded on less than gen12 platform

On Thu, Mar 25, 2021 at 03:44:04PM +0530, Anand Moon wrote:

quoted

Added check for testcase to get discarded on less than gen12 platform

Cc: Lionel Landwerlin <redacted>
Cc: Umesh Nerlige Ramappa <redacted>
Signed-off-by: Anand Moon <redacted>
---
 tests/i915/perf.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/i915/perf.c b/tests/i915/perf.c index

664fd0a9..18cf9fb1 100644

--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c

@@ -5062,19 +5062,20 @@ igt_main
 }

 igt_subtest_group {
-igt_fixture igt_require(intel_gen(devid) >= 12);
+if (intel_gen(devid) >= 12) {

You can't do that. Tests must exist regardless of the running platform.

Thanks for the input. So to resolve this issue I need to fix the subtest.

What is there to fix? Those subtests skipping on gen<12 sounds like
the proper behaviour.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev