Thread (3 messages) 3 messages, 2 authors, 2021-03-19

[igt-dev] [i-g-t, v3] tests/kms_content_protection: Initialize fb height width to 0

From: Tejas Upadhyay <hidden>
Date: 2021-03-19 12:43:13
Subsystem: the rest · Maintainer: Linus Torvalds

While requesting for framebuffer height and width should be in
kernel expected limit. As the test is not initializing height
and width to 0 garbage framebuffer size is getting requested and
fails. Addressed same, initalizing height and width to 0.

"Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3144"
"Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3137"

Changes since V2:
	- Add bug close notes to commit message
Changes since V1:
	- Added igt_display_require_output(&data.display)
	- Removed extra newlines

Reviewed-by: Petri Latvala <redacted>
Signed-off-by: Tejas Upadhyay <redacted>
---
 tests/kms_content_protection.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
index 0c2173fb..0fdbacdd 100644
--- a/tests/kms_content_protection.c
+++ b/tests/kms_content_protection.c
@@ -707,7 +707,7 @@ static void test_content_protection_cleanup(void)
 static void create_fbs(void)
 {
 	igt_output_t *output;
-	int width, height;
+	int width = 0, height = 0;
 	drmModeModeInfo *mode;
 
 	for_each_connected_output(&data.display, output) {
@@ -730,9 +730,8 @@ igt_main
 {
 	igt_fixture {
 		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
-
 		igt_display_require(&data.display, data.drm_fd);
-
+		igt_display_require_output(&data.display);
 		create_fbs();
 	}
 
-- 
2.30.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help