Re: [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb
From: Ville Syrjälä <hidden>
Date: 2021-03-18 12:49:29
Also in:
nouveau
On Wed, Mar 17, 2021 at 06:49:46PM -0400, Lyude wrote:
From: Lyude Paul <lyude@redhat.com> It doesn't look like that this is used by i915 for anything these days, so let's just remove this while we're at it.
I wa scurious why this is here so dug around a bit.
It was added in
commit 18d0b1efb875 ("lib/igt_fb: Fix domain tracking for GTT cairo surfaces")
then got broken again by
commit 89b3ffe02c2a ("lib: Map dumb buffers")
and later fixed again with
commit 3bd68529c464 ("lib/igt_fb: Add missing set_domain calls")
So yeah, not needed anymore.
Reviewed-by: Ville Syrjälä <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Lyude Paul <lyude@redhat.com> Cc: Martin Peres <redacted> Cc: Jeremy Cline <redacted> --- lib/igt_fb.c | 3 --- lib/igt_fb.h | 2 -- 2 files changed, 5 deletions(-)diff --git a/lib/igt_fb.c b/lib/igt_fb.c index f0fcd1a7..2b478887 100644 --- a/lib/igt_fb.c +++ b/lib/igt_fb.c@@ -2491,7 +2491,6 @@ static void create_cairo_surface__gpu(int fd, struct igt_fb *fb) cairo_format, fb->width, fb->height, blit->linear.fb.strides[0]); - fb->domain = I915_GEM_DOMAIN_GTT; cairo_surface_set_user_data(fb->cairo_surface, (cairo_user_data_key_t *)create_cairo_surface__gpu,@@ -2571,8 +2570,6 @@ static void create_cairo_surface__gtt(int fd, struct igt_fb *fb) "Unable to create a cairo surface: %s\n", cairo_status_to_string(cairo_surface_status(fb->cairo_surface))); - fb->domain = I915_GEM_DOMAIN_GTT; - cairo_surface_set_user_data(fb->cairo_surface, (cairo_user_data_key_t *)create_cairo_surface__gtt, fb, destroy_cairo_surface__gtt);diff --git a/lib/igt_fb.h b/lib/igt_fb.h index 0d64898a..e4f8b2b1 100644 --- a/lib/igt_fb.h +++ b/lib/igt_fb.h@@ -64,7 +64,6 @@ struct buf_ops; * @modifier: tiling mode as a DRM framebuffer modifier * @size: size in bytes of the underlying backing storage * @cairo_surface: optionally attached cairo drawing surface - * @domain: current domain for cache flushing tracking on i915.ko * @num_planes: Amount of planes on this fb. >1 for planar formats. * @strides: line stride for each plane in bytes * @offsets: Offset for each plane in bytes.@@ -87,7 +86,6 @@ typedef struct igt_fb { uint64_t modifier; uint64_t size; cairo_surface_t *cairo_surface; - unsigned int domain; unsigned int num_planes; uint32_t strides[4]; uint32_t offsets[4];-- 2.29.2 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
-- Ville Syrjälä Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev