Thread (7 messages) 7 messages, 5 authors, 2021-03-18

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

From: Petri Latvala <hidden>
Date: 2021-03-18 09:27:00
Also in: nouveau

On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote:
On 18/03/2021 00:45, Lyude wrote:
quoted
From: Lyude Paul <lyude@redhat.com>

Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at
least test both of them.
This adds 36 subtests, which take about 1s in average. So the runtime is not
significantly increased on the Intel side.

It also seems that Intel should add skips or fix the kernel to support these
32xXX format.

@Petri, could you get someone to investigate this?

Ville, J-P?


-- 
Petri Latvala


In the mean time, here is my:

Reviewed-by: Martin Peres <redacted>

Martin
quoted
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <redacted>
Cc: Ben Skeggs <redacted>
Cc: Jeremy Cline <redacted>
---
  tests/kms_cursor_crc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 0be8f7f8..c70c4a8f 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -683,7 +683,7 @@ static void run_tests_on_pipe(data_t *data, enum pipe pipe)
  	igt_fixture
  		igt_remove_fb(data->drm_fd, &data->fb);
-	for (cursor_size = 64; cursor_size <= 512; cursor_size *= 2) {
+	for (cursor_size = 32; cursor_size <= 512; cursor_size *= 2) {
  		int w = cursor_size;
  		int h = cursor_size;
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help