Re: [igt-dev] [PATCH i-g-t] tests/kms_vblank:Added subtest description
From: Modem, Bhanuprakash <hidden>
Date: 2021-01-28 12:24:51
quoted hunk ↗ jump to hunk
-----Original Message----- From: igt-dev <redacted> On Behalf Of Arundhati Hagaragi Sent: Sunday, January 17, 2021 6:57 PM To: igt-dev@lists.freedesktop.org Cc: S@freedesktop.org; B@freedesktop.org Subject: [igt-dev] [PATCH i-g-t] tests/kms_vblank:Added subtest description Added description for all subtests Signed-off-by: Arundhati Hagaragi <redacted> Cc: B S, Karthik <redacted> --- tests/kms_vblank.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index b00ebec5..c71b8c24 100644 --- a/tests/kms_vblank.c +++ b/tests/kms_vblank.c@@ -438,6 +438,7 @@ static void run_subtests_for_pipe(data_t *data) if (m->flags & ~(f->valid | NOHANG)) continue; + igt_describe("checks if test run with NOHANG flag set");
Still, it is not clear what this test does. It would be good to add some info about the test. Suggestion: If there are multiple tests available & difficult to describe in generic way, we can add a new member "desc" to the struct funcs and print.
quoted hunk ↗ jump to hunk
igt_subtest_f("pipe-%s-%s-%s", kmstest_pipe_name(data->pipe), f->name, m->name) {@@ -451,6 +452,7 @@ static void run_subtests_for_pipe(data_t *data) if (f->valid & NOHANG || m->flags & NOHANG) continue; + igt_describe("check if injected hang is workingproperly"); igt_subtest_f("pipe-%s-%s-%s-hang", kmstest_pipe_name(data->pipe), f->name, m->name) {@@ -521,9 +523,11 @@ igt_main igt_display_require_output(&data.display); } + igt_describe("check if test reports INVALID error for garbagevalues");
We are trying with different invalid combinations not garbage values. How about "Negative test for vblank request" ?
igt_subtest("invalid")
invalid_subtest(&data, fd);
+ igt_describe("check the IOCTL events works with given crtc id");How about s/"IOCTL events"/"Vblank & Flip events"/r ?
igt_subtest("crtc-id")
crtc_id_subtest(&data, fd);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev_______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev