Thread (5 messages) 5 messages, 3 authors, 2018-10-03

Re: [igt-dev] [PATCH i-g-t 1/1] runner: Add time_elapsed field to results

From: Petri Latvala <hidden>
Date: 2018-10-03 10:27:19

On Wed, Oct 03, 2018 at 12:06:35PM +0300, Arkadiusz Hiler wrote:
On Thu, Sep 27, 2018 at 04:11:42PM +0300, Petri Latvala wrote:
quoted
When starting a test run, drop a timestamp file. Do the same when
ending a run. Slap those timestamps directly into the time_elapsed
field in results.json.

Using timestamps instead of measuring actual elapsed time goes against
the naming of the field, but the name is chosen by piglit. Even though
piglit itself uses timestamps.

Corner cases:

On incomplete test runs, the end timestamp will be missing. The
time_elapsed field will only have the start timestamp. This matches
piglit behaviour exactly.

On incomplete but resumed test runs, the end timestamp will be the
time when the resume finishes. Piglit doesn't do this, and instead
leaves the end timestamp missing. Discussing which behaviour is better
is left as an exercise to the readers.

Signed-off-by: Petri Latvala <redacted>
Cc: Arkadiusz Hiler <redacted>
Cc: Tomi Sarvela <redacted>
Reviewed-by: Arkadiusz Hiler <redacted>

Once this gets merged we will have to update IGT on the the CI host.
Merged now, thanks.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help