On Sun, 8 Nov 2026 at 05:44, Junio C Hamano [off-list ref] wrote:
Junio C Hamano [off-list ref] writes:
quoted
Needless to say, with this patch applied, the following tests would
now fail, unable to find "test-tool genzeros".
Not really. Even though the source file is renamed, the dispatcher
inside still recognises genzeros and calls cmd__genzeros. In fact,
at this stage, "test-tool genbytes" would not even work (and it does
not have to work as nobody calls it).
So, sorry for the false alarm, but my point about not split the
rename + modification into two separate steps still stands.
[...]
quoted
FWIW, if you apply [1/3] and [2/3], squash them together, then give
a custom rename factor to the command, e.g.,
$ git format-patch -M3 -1
to format the resulting single patch, you will see a modification of
genzeros while the file gets renamed just fine, and you would not
have to break these tests in the middle of a series.
When using the GGG workflow I think that option is not available,
though I will see if I can try formatting and sending the patch
manually for this one instead. (Or try to submit a patch to GGG
to allow for configuring this too.)
I could squash it all into a single patch too, which I think
would make sense if we don't need the intermediate state
where both genzeros and genbytes exist at the same time.
What's your preference?
Thanks,
Kristofer