Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine

From
Jeff King <hidden>
Date
2026-11-05 18:56:41
Reply to
Kristofer Karlsson, 2026-11-04
On Wed, Nov 04, 2026 at 11:25:38AM +0100, Kristofer Karlsson wrote:
No, I think you are right.  The quarantine parent only matters when
the object directory is not under the commondir, which is rare.  Your
version is essentially my v1 without the "this is a hack" framing
(and also cleaner).
What we really want is "where are we reading our local refs from" (to
avoid reading them again). So even if you have an object directory not
under the commondir, we would not find our repo again by looking at the
parent of that directory.

But I also won't be surprised if there is some arcane working tree setup
that I'm missing.

Anyway, what's in your v3 looks good to me. Thanks for fixing this!

-Peff
Thread (24 messages) 24 messages, 6 authors, last reply 3d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help