Re: [PATCH] api-parse-options: add missing flags and macros

From
Cynthia Uche <hidden>
Date
2026-11-05 12:25:58
Reply to
Karthik Nayak, 2026-11-05
Hi Karthik,

On Thu, Nov 5, 2026 at 11:37 AM Karthik Nayak [off-list ref] wrote:
Also add the follow missing macros:
nit: s/follow/following/.
- OPT_NO_WITH
The message lists OPT_NO_WITH, but parse-options.h defines
OPT_WITHOUT, which is what the diff documents. The diff also adds
OPT_BITOP, OPT_STRVEC, OPT_UYN, OPT_NOOP_ARG and OPT_COLUMN, which
the message doesn't list.

I applied this on its base (8d1b215c01), built the docs with no
warnings, and compared the descriptions with the code on master
(0ffa3e35c7). OPT__VERBOSITY, OPT_UYN, OPT_BITOP, OPT_COLUMN,
OPT_CONTAINS, OPT_NOOP_ARG and the two new flags match
parse-options.c and parse-options-cb.c, and the git-add[1]
references resolve via diff-context-options.adoc.

OPT_ALIAS and OPT_ALIAS_F are still undocumented tho. I wonder if that
is on purpose.

-- 
Cynthia
Thread (6 messages) 6 messages, 2 authors, last reply 2d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help