Re: [PATCH 0/2] odb/source-loose: fix failing existence checks caused by stale cache

From
Kristofer Karlsson <hidden>
Date
2026-11-04 12:58:06
Reply to
Patrick Steinhardt, 2026-11-04
On Wed, 4 Nov 2026 at 13:17, Patrick Steinhardt [off-list ref] wrote:
Hi,

this small patch series fixes the bug reported in [1].

In summary, when git-merge(1) writes merged blobs it may be unable to
read them back because the loose object cache does not get updated.
Consequently, we may think that the blobs do not exist locally, and thus
in a promisor remote we may perform a backfill fetch. But as the remote
doesn't know those objects we'll fail.

Thanks!

Patrick
The fix looks good to me, and I verified that the test fails
without it. My own local fix is logically equivalent,
which is a good sign, though perhaps that biased my review.

Thanks,
Kristofer
Thread (10 messages) 10 messages, 5 authors, last reply 2d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help