Hello Kaartic,
Thank you so much for taking the time to review this.
On Fri, 30 Oct 2026 at 12:44, Kaartic Sivaraam
[off-list ref] wrote:
Just a gentle reminder about this portion of the MyFirstContribution[1]:
It’s good manners to reply to each comment in the mailing list
discussion instead of letting the next version of your patch be your
only response. Tell the reviewer whether you plan to make the
suggested change, keep the original, or pursue a different approach.
Thanks for the reminder about replying to comments. I'll do that from
now on.
May be give a hint that you plan to do this in the following commit?
That might give someone without context (for example someone reading the
commit after a while) a hint about why you are worrying about marking
fast-import with the NO_PARSEOPT flag.
Alright, I'll add a sentence to the commit message saying that the
next commit removes the NO_PARSEOPT flag from fast-import, which would
make "git fast-import --<TAB>" freeze without this patch.
The change seems to be fine but I wonder if it is worth a note in
parse-options.h about why show_usage_with_options_if_asked() is also
handling the '--git-completion-helper' and '--git-completion-helper-all'
arguments?
Yes, I think that would help, so I will add a short comment above its
declaration in parse-options.h explaining that it answers these before
the command does any work.
Thanks,
Tanga