Re: [PATCH v2 0/4] loose: fix migrating "loose-object-idx" with batch fsync

From
Justin Tobler <hidden>
Date
2026-10-29 22:45:58
Reply to
Junio C Hamano, 2026-10-29
On 26/10/29 03:22PM, Junio C Hamano wrote:
Merging this topic to 'seen' had a funny interaction with other
topics in flight.  repo_write_loose_object_map() function, from
which loose_object_map_write() helper function was extracted out of,
loses all callers, and will disappear in the merge.  But the new
helper, which gained a caller loose_object_idx_merge() in this
series, remains.
Thanks for the heads up. I see the function gets dropped by de2910a42b
(loose: drop unused `repo_write_loose_object_map()`, 2026-10-27).
Keeping the new helper and dropping `repo_write_loose_object_map()` is
indeed the correct resolution.

It does look like in `seen` the declaration of
`repo_write_loose_object_map()` is still left behind in "loose.h"
though.

I have a few small changes queued up locally for a v3, which I will send
out soon.

Thanks,
-Justin
Thread (34 messages) 34 messages, 4 authors, last reply 2d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help