Thread (12 messages) 12 messages, 4 authors, 20h ago

Re: [PATCH 0/7] builtin/commit-graph: some small cleanups

flat view

From: Karthik Nayak <hidden>
Date: 2026-10-29 12:55:18

Junio C Hamano [off-list ref] writes:
Patrick Steinhardt [off-list ref] writes:
quoted
Hi,

I'm working into the direction of making commit-graphs pluggable so that
backends can fully control where exactly commit-graphs are written to
and read from. This patch series contains a couple of small preliminary
cleanups.

Most of the patches are rather uncontroversial, I'd assume. The only
one that might raise some eyebrows is where I "fix" git-commit-graph(1)
to only accept "--object-directory=" for subcommands instead of both as
a command-global and subcommand option. I feel like this is quite a weird
outlier, and it got in my way. In any case, I'd appreciate some extra
thoughts on this.

Thanks!

Patrick
I read the first 4 steps and they all looked sensible.  May come
back to the remainder later this week if nobody beats me to it.

Thanks.
I didn't beat you to it, but I too have nothing to object here,
everything looks to be in order :)

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help