Re: [PATCH 0/8] ci: consolidate test variables

Hi Patrick

On 27/10/2026 08:18, Patrick Steinhardt wrote:

Hi,

this patch series consolidates our test variables as a follow up on the
discussions in [1].

The series is built on top of 37b3475fb53 (The 9th batch, 2026-10-25).

I looked at the diff for the whole series rather than the individual patches and it looks nice. The changes to move all the job dependent variable assignments into ci/lib.sh and the removal of the linux-reftable-sha256 job while maintaining our coverage are very welcome. It probably makes sense to disable rust for the sanitizer job which is aimed at checking our C code, though if we end up with more unsafe rust in the future maybe the balance will shift?

Thanks

Phillip

Thanks!

Patrick

[1]: [ref]

---
Patrick Steinhardt (8):
       ci: consolidate setup of test environment
       ci/lib: always set GIT_TEST_USE_SET_E on Linux jobs
       ci/lib: deduplicate test variables by pattern matching
       ci/lib: merge switches for specific job names
       t: honor default ref storage format
       ci/lib: add another NO_RUST build using glibc
       ci: don't override initial branch name in testbed job
       t/test-lib: make feature-testbed job more accessible

  .github/workflows/main.yml |  3 ---
  .gitlab-ci.yml             |  3 ---
  ci/lib.sh                  | 34 ++++++++++++++++++++++++++++++++--
  ci/run-build-and-tests.sh  | 44 --------------------------------------------
  t/README                   |  5 +++++
  t/test-lib-functions.sh    |  2 +-
  t/test-lib.sh              | 25 ++++++++++++++++++++++++-
  t/unit-tests/unit-test.c   |  1 +
  8 files changed, 63 insertions(+), 54 deletions(-)


---
base-commit: 37b3475fb530c14109211faca33716a173db61ed
change-id: 20261016-b4-pks-ci-test-vars-consolidation-8d0c6a53ca28