Re: [Outreachy PATCH] delta-islands: use Q_() for island count

From
Okhuomon Ajayi <hidden>
Date
2026-10-13 19:44:24
Reply to
Junio C Hamano, 2026-10-13
On Tue, Oct 13, 2026 at 7:00 PM Junio C Hamano [off-list ref] wrote:
I am not sure of the value in this, though.  You certainly do not
mean to say that you updated all of the ones that you found with the
above.  You are not inviting others to do the same grep and "fix"
any of the hits, as the pattern gives too many false positives
(i.e., not all %d are about number of things, like the line number a
parser has found the error it is reporting at), and without warning
that, it would not be helpful to these others.
You are right, I will remove it from the commit message and send a v2.
The change itself looks sensible to me.
Thank you for the review.

Okhuomon

Okhuomon
Thread (8 messages) 8 messages, 3 authors, last reply 25d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help