Thread (27 messages) 27 messages, 4 authors, 9d ago

Re: [PATCH v3 0/5] repack: don't lose objects to a ".keep" that appears mid-run

flat view

From: Junio C Hamano <hidden>
Date: 2026-10-08 19:19:16

"qeesung via GitGitGadget" [off-list ref] writes:
Interaction with topics in seen:

 * ps/odb-files-alternates turns the list of object sources into a single
   files source with a list of object directories, so
   repo_invalidate_kept_pack_caches() from 2/5 needs to walk those instead.
   The textual merge is clean, but the build breaks; this resolution follows
   has_object_kept_pack() on that topic:
   
   void repo_invalidate_kept_pack_caches(struct repository *r) { struct
   odb_source_files *files = odb_source_files_downcast(r->objects->source);
   for (struct odb_files_dir *dir = files->dirs; dir; dir = dir->next)
   invalidate_kept_pack_cache(dir->packed); }
I do not know if you meant to cram a function on four lines this
way, but I suspect that it may be easier for everybody to stop and
wait until the other topic solidifies a bit more, and then create a
synthetic base that merges the other topic into the tip of 'master'
and rebase these five patches on top of the resulting merge.

I wonder how close ps/odb-files-alternates topic is to the finish
line?  Karthik did read through the initial round and then gave a
thumbs up on the current iteration.  We would benefit from a
different set of eyes on the series [*].

Thanks.

[Reference]

* [ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help