Thread (70 messages) 70 messages, 3 authors, 5d ago

Re: [PATCH v5 0/5] Introduce 'uploadpack.lazyFetchTrusted'

flat view

From: Christian Couder <hidden>
Date: 2026-10-06 14:54:37

On Mon, Oct 5, 2026 at 5:37 PM Junio C Hamano [off-list ref] wrote:
Christian Couder [off-list ref] writes:
quoted
Changes since v4
================

Thanks to Junio for reviewing previous versions of this series.

Rebased on top of a018953688 (Git 2.56, 2026-09-27) to be on a stable
base.

There are no functional code changes compared to v4. Only code
comments, documentation, tests and commit messages have changed, and
those changes are relatively small.

 - In patch 2/5, a NEEDSWORK code comment has been added to say that
   we may want to warn in case of a missing path unless that path is
   marked with an ":(optional)" prefix. Also the commit message
   now mentions that NEEDSWORK code comment.

I was hoping to see more substantial reviews from others (compared
to my rather nitpicky review on v4), but nobody has bitten yet.  Shall
we declare that we have reached the point of diminishing returns and
mark the topic for 'next'?
Yes, I think this series doesn't introduce a lot of new code or
features. It's mostly refactorings and a new protected configuration
variable (along with documentation and tests). So I don't think it's
worth waiting for more reviews.

Thanks for your reviews.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help