Re: [PATCH v2 0/3] refs/reftable: fix on-disk representation of reflog timezones

Patrick Steinhardt [off-list ref] writes:

Hi,

it was reported [1] that the way we store reflog timezones with the
reftable format has a mismatch with the reftable specification. While
the spec says that reftables should be stored as a signed offset in
minutes, we store them in the "[+-]HHMM" format that we typically use in
commit headers, for example.

This patch series fixes this bug by making our on-disk representation
match the specification. This will of course make us reinterpret old
reftables. But ultimately, the fallout caused by this change is somewhat
limited as we only ever use reflog timezones for display purposes. So
yes, we'll display a wrong timezone. But it's not used as part of any
kind of computations.

The series is built on top of v2.56.0.

Changes in v2:
  - Improve readability of one of the converted sites that now use
    `minutes_to_tz()`.
  - Improve test coverage.
  - Link to v1: https://patch.msgid.link/20260929-pks-reftables-fix-timezone-format-v1-0-3df105a95ed1@pks.im

The range-diff looks in order. This version looks good to me!

[snip]