Re: [PATCH v2] fetch.c: defer fetch.followRemoteHEAD validation

On Fri Sep 25, 2026 at 4:30 PM EDT, Colin Hinton wrote:

On Fri, Sep 25, 2026 at 12:40 PM Junio C Hamano [off-list ref] wrote:

quoted

We should do something similar to what remote.c parses for
consistency, but other than that, it seems this topic is moving in
the right direction.

Thanks.

The only critical difference I see in the configuration parse between
remote.c and fetch.c is the case for "warn-if-not-$branch". From
reading the git-config manpage, this is only a setting for a remote
and not for fetch directly so I do not see a reason to check this in
fetch.c. Perhaps I am missing something else to make this more
consistent,

I agree with this assessment.  However, I wonder if Junio meant

    We should (do something similar) to (what remote.c parses) ...

instead of

    We should do (something similar to what remote.c parses) ...

as the issue in the NEEDSWORK _does_ apply to both sides.

Perhaps at a minimum, this patch should leave the comment intact (or
reworded) if not yet addressing remote.c.  v3 otherwise is looking good
to me, and functionality seems to work.