Thread (36 messages) 36 messages, 5 authors, 4h ago

Re: [PATCH] ci: point leak-sanitizer failures at the actual test and error

From: Harald Nordgren <hidden>
Date: 2026-09-27 19:53:07

quoted
     ci: point leak-sanitizer failures at the actual test and error

     I discovered while running CI on another GitHub pull request that it's
     very hard to see where the error is for the leak tests.

     This will stop each leak-sanitizer script at its first failure and
     points annotations at the real file and error.
Putting the leak output in the test results is very welcome, but does
this mean that if there are two leaks we only report one?
It already had a behavior where one failure made every subsequent test
in the script report "not ok" too, so lots of noise burying the real
leaks.
quoted
     Proof that it works:
     https://github.com/git/git/actions/runs/35871180948/job/107215430244
Opening that link shows that the individual test failures are no-longer
folded and I see some very strange scrolling behavior in firefox - when
the page opens it scrolls to the bottom of the output of
"ci/build-and-run-tests.sh" and if I try to scroll up it immediately
scrolls back down as soon as my fingers leave the touchpad.
I'll take a look at that.
The patch below seems to do more than just changing the output to
display the leak backtrace - it adds some escaping and changes the
annotations. There is no explanation of what these changes do or why
they are required.
I'll expand the commit message.


Harald
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help