Re: [PATCH] ci: fix unit tests not running on windows
From: Patrick Steinhardt <hidden>
Date: 2026-09-24 14:14:07
On Thu, Sep 24, 2026 at 03:09:18PM +0200, Karthik Nayak wrote:
Since 3141df7ec4 (ci: don't skip smallest test slice in GitLab, 2026-02-19) both our CI workflows at GitLab and GitHub use one-indexed slices to run windows tests. Modify the check for running unit tests on Windows to also be one-indexed as otherwise, the unit tests are never run.
Oh, that's something that I missed indeed. At least we've still been running unit tests via Meson :)
quoted hunk ↗ jump to hunk
diff --git a/ci/run-test-slice.sh b/ci/run-test-slice.sh index ff948e397f..d0063efc42 100755 --- a/ci/run-test-slice.sh +++ b/ci/run-test-slice.sh@@ -10,8 +10,8 @@ TESTS=$(cd t && ./helper/test-tool path-utils slice-tests "$1" "$2" t[0-9]*.sh) group "Run tests" make --quiet -C t T="$(echo "$TESTS" | tr '\n' ' ')" || handle_failed_tests -# We only have one unit test at the moment, so run it in the first slice -if [ "$1" == "0" ] ; then +# We only have one unit test at the moment, so run it in the first slice. +if [ "$1" == "1" ] ; then group "Run unit tests" make --quiet -C t unit-tests-test-tool fi
The diff looks good to me, thanks! Patrick