Re: [GSoC Patch v6 2/7] repo: add path.superproject-root with absolute and relative suffixes

On Sat, Sep 12, 2026 at 3:39 AM Junio C Hamano [off-list ref] wrote:

Correcting get_superproject_working_tree(), which was introduced by
bf0231c661 (rev-parse: add --show-superproject-working-tree,
2017-03-08), is a major part of this step.  The old commit added a
single test for very basic use but this step makes not-so-basic use
cases to also work correctly, right?

It may be a good idea to split this step into two patches:

 - a patch that corrects get_superproject_working_tree(), that adds
   a new test or two to t1500-rev-parse.sh, next to where bf0231c661
   (rev-parse: add --show-superproject-working-tree, 2017-03-08)
   added its test.  The test would fail without the code fix to
   demonstrate what we improved.

 - another patch that uses improved get_superproject_working_tree()
   to add path.superproject-root.* keys, together with the updates
   to t1900-repo-info.sh to add tests for the new feature.

Fair enough. Will do, but I don't think t1500 is a good location tho
Cause the bug affects repo as well
I will find a good location.