Re: history: 'reword HEAD' surfaces a memory leak

On Mon, Sep 7, 2026, at 14:12, Patrick Steinhardt wrote:

On Mon, Sep 07, 2026 at 05:16:44PM +0530, Kaartic Sivaraam wrote:

quoted

On 9/7/26 16:43, Patrick Steinhardt wrote:

quoted

This feels familiar, even though it doesn't reproduce on my machine. Do
you have "i18n.commitencoding" set? In any case, I think the following
patch should fix it:

[snip]

My bad, I suppose. There was a suggestion by Peff that the commit message
was misleading. Per [2], the leak only happens when we get a commit that
isn't cached in the commit slab. I was trying to identify the specific case
in which we get a commit that's not cached in the slab but eventually got
busy with other work. I will get around to it soon and send a long pending
re-roll.

[[ References ]]

[2]:
https://lore.kernel.org/git/94b0bed5-c86a-4291-b958-52f09faebd29@gmail.com/ (local)

Awesome, thanks!

Thanks, everyone. It makes sense that the commit graph was the
triggering factor.