Re: [PATCH v3] Move rust gitcore crate to a different subdirectory

Mike Hommey [off-list ref] writes:

Having `Cargo.toml` at the top-level of the repository implies that one
can run `cargo build` directly, but this doesn't produce anything useful
on its own.

Additionally, when including the git source as a submodule of a Rust
project, it prevents the git source from being included at all in the
crate package because cargo skips directories that contain a Cargo.toml,
assuming that everything in the directory is relevant to the crate.

This moves all Rust-specific files into a dedicated `rust/`
subdirectory.

Very readable and understandable.  It is customary in this project
to write that last sentence in imperative mood, though.  I.e.  "Move
all files there".

Signed-off-by: Mike Hommey <redacted>

There are /target/ and /Cargo.lock listed in this file; aren't these
two entries meant to _replace_ them?  I am wondering if they need to
disappear as part of this patfch.

+RUST_SOURCES += rust/src/csum_file.rs
+RUST_SOURCES += rust/src/hash.rs
+RUST_SOURCES += rust/src/lib.rs
+RUST_SOURCES += rust/src/loose.rs
+RUST_SOURCES += rust/src/varint.rs
+RUST_SOURCES += rust/src/lib.rs
+RUST_SOURCES += rust/src/varint.rs

Two files, lib and varint, are listed twice here.  A rebase error or
something?

The Cargo.lock file does not move together with the rest?  That
contradicts with what .gitignore says, doesn't it?