Thread (98 messages) flat view 98 messages, 7 authors, 6d ago

Re: [PATCH v7 4/4] hook: introduce the receive-report hook

From: Junio C Hamano <hidden>
Date: 2026-09-07 20:58:03

Karthik Nayak [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -2469,6 +2510,12 @@ static void report(struct command *commands, const struct strbuf *unpack_status,
 
 	generate_report(&buf, commands, unpack_status, version);
 
+	if (run_receive_report_hook(&buf)) {
+		strbuf_reset(&buf);
+		override_cmds_error(commands, "receive-report hook failed");
+		generate_report(&buf, commands, unpack_status, false);
+	}
Hmph, what does 'false' mean here?  Didn't you mean to use the same
"version" like you used in the previous call in the preimage?

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help