Thread (10 messages) flat view 10 messages, 2 authors, 8d ago

Re: [PATCH 4/4] worktree add: let worktree_basename() return string copy

From: Junio C Hamano <hidden>
Date: 2026-08-31 18:56:44

Junio C Hamano [off-list ref] writes:
quoted
quoted
So going back to the confusing part of the log message,

    Remind ... to worktree_basename_dup().  Among the three callers
    of worktree_basename(), two immediately make copies of the
    returned string before using and freeing it, which makes for an
    easy conversion.  Convert the other one from resetting ...

or something like that, perhaps?
Yes.
Thanks.  We do not know if other parts of the series gets more
serious reviews that necessitates an updated version, so in the
meantime I'll reword what I have locally.
And nothing happened since then.  As the topic was in a good shape
except for the confusing part of the log, which we amended in my
tree already, let's mark the topic for 'next'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help