Thread (13 messages) flat view 13 messages, 4 authors, 27d ago

Re: [PATCH v2] die_for_incompatible_opts(): unbounded number of options

From: Junio C Hamano <hidden>
Date: 2026-08-30 20:55:34

Jeff King [off-list ref] writes:
On Thu, Aug 27, 2026 at 10:28:32AM -0700, Junio C Hamano wrote:
quoted
+void die_for_incompatible_opts(bool opt1, const char *opt1_name, ...)
I'm mildly negative on this, just because there's no compiler support
for making sure there is an EOF somewhere. Keeping patch 1 and using
LAST_ARG_MUST_BE_NULL would be preferable, IMHO.
Let's discard this topic for now.

I do not like the second iteration very much, and I do not like the
1/2 preliminary step of the first iteration even less so.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help