Re: [PATCH] commit: refuse to amend during conflict resolution
From: Junio C Hamano <hidden>
Date: 2026-08-26 16:39:28
"Elijah Newren via GitGitGadget" [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -1336,6 +1337,46 @@ static int parse_and_validate_options(int argc, const char *argv[], else if (whence == FROM_REBASE_PICK) die(_("You are in the middle of a rebase -- cannot amend.")); }
Let's make a mental note that the function receives these parameters: static int parse_and_validate_options(int argc, const char *argv[], const struct option *options, const char * const usage[], const char *prefix, struct commit *current_head, struct wt_status *s)
+ if (amend && whence == FROM_COMMIT) {
+ char *applying, *apply_dir, *stopped_sha, *amend_marker;
+ int in_am, conflicted_stop;
+
+ /* Check middle of revert */
+ if (refs_ref_exists(get_main_ref_store(the_repository),
+ "REVERT_HEAD"))
+ die(_("You are in the middle of a revert -- cannot amend."));"the_repository" can become "s->repo". The same comment for other checks in this block.