Thread (42 messages) flat view 42 messages, 7 authors, 8d ago

Re: [PATCH v2 5/7] trace2: remove use of xstrfmt()

From: Elijah Newren <hidden>
Date: 2026-08-25 22:15:02

On Tue, Aug 25, 2026 at 11:59 AM Derrick Stolee via GitGitGadget
[off-list ref] wrote:
[...]
+       const char *redact = ":<REDACTED>";
+       char *redacted;
[...]
+       memcpy(redacted, arg, prefix_len);
+       memcpy(redacted + prefix_len, redact, redact_len - 1);
Only copy redact_len - 1 bytes?  So only ":<REDACTED" without the
trailing ">" ?  Why?

+       memcpy(redacted + prefix_len + redact_len - 1, p + at,
+              suffix_len + 1);
+       return redacted;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help