Thread (26 messages) flat view 26 messages, 5 authors, 11d ago

Re: [PATCH v2 4/4] reftable/stack: avoid reloading the stack when already locked

From: Jeff King <hidden>
Date: 2026-08-24 22:52:04

On Mon, Aug 24, 2026 at 11:31:02AM +0200, Karthik Nayak wrote:
Benchmarking with a fixed, non-symbolic target OID in the 'refs/tags/'
namespace (since it triggers a stack reload when checking if reflog
exists for the given tag name), shows a consistent 15-20% improvement
with these patches:

  refcount   master     patch     speedup
  --------   -------    -------   -------
  2,000       18.5 ms    16.6 ms   1.11x
  20,000     120.7 ms   102.8 ms   1.17x
  50,000     296.5 ms   247.1 ms   1.20x
Much nicer. :)

I'm not very familiar with the reftable code, so you can take my review
with a huge grain of salt. But I think the idea is sound, and I didn't
see anything obviously wrong. Thanks for working on this.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help