Re: [PATCH v2] pack-objects: trace pack bytes written

On Wed, Aug 19, 2026 at 04:28:10PM -0700, friel@openai.com wrote:

From: Friel <redacted>

We want to measure how compression settings affect push performance on
the client. Different settings can produce different-sized packs from
the same objects. Trace2 records the object count, but we also need the
pack size to compare those settings.

Add a write_pack_file/wrote_bytes Trace2 datum alongside
write_pack_file/wrote. Count packs written to stdout or disk, including
each pack's header and trailing checksum. When pack.packSizeLimit splits
the output, report the sum of the pack sizes.

Signed-off-by: Friel <redacted>
---
Junio, you're right. Updating bytes_written before finalization is
equivalent. I've dropped pack_bytes; everything else is unchanged.
Thanks.

The downthread discussion went pretty far off-topic, so for those who do
not want to read it, the summary is: this patch looks good to me. ;)

-Peff