Thread (18 messages) flat view 18 messages, 5 authors, 17d ago

Re: [PATCH v3 2/4] completion: complete 'git history --empty' values

From: Patrick Steinhardt <hidden>
Date: 2026-08-19 11:13:34

On Thu, Aug 13, 2026 at 09:05:03PM +0200, Vincent Mailhol wrote:
quoted hunk ↗ jump to hunk
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 1727768487..7f3cabd595 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2169,6 +2169,15 @@ _git_history ()
 
 	if ! __git_has_doubledash; then
 		case "$cur" in
+		--empty=*)
+			case "$subcommand" in
+			drop|fixup)
+				__gitcomp "drop keep abort" "" \
+					"${cur##--empty=}"
+				;;
+			esac
+			return
+			;;
It would've been fine to just do this for every subcommand, I guess. But
this version works for me, too.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help