Thread (20 messages) flat view 20 messages, 3 authors, 4d ago

Re: [PATCH 4/4] format-rev: learn --abbrev, --color, and --date

From: Kristoffer Haugsbakk <hidden>
Date: 2026-08-18 05:11:43

On Thu, Aug 13, 2026, at 19:24, kristofferhaugsbakk@fastmail.com wrote:
[snip]
+static int date_cb(const struct option *option,
+		   const char *arg,
+		   int unset)
+{
+	struct rev_info *data = option->value;
+	parse_date_format(arg, &data->date_mode);
The documentation for this function says that we need to call a release
function in case a custom format was used. That is currently missing.
+	data->date_mode_explicit = 1;
+	BUG_ON_OPT_NEG(unset);
+	return 0;
+}
+
[snip]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help