Thread (3 messages) flat view 3 messages, 3 authors, 27d ago

Re: [PATCH] serve: reject valueless promisor-remote capability

From: Elijah Newren <hidden>
Date: 2026-08-12 21:27:57

On Tue, Aug 11, 2026 at 11:39 PM Elijah Newren via GitGitGadget
[off-list ref] wrote:
From: Elijah Newren <redacted>

d460267613da (Add 'promisor-remote' capability to protocol v2,
2025-02-18) added a receive callback which passes the capability value
directly to mark_promisor_remotes_as_accepted(). However, a client can
send the capability name without an '=' or value, in which case
get_capability() supplies NULL and strbuf_split_str() dereferences it.
Oops, I previously forgot to CC Christian as the author of
d460267613da.  Doing that now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help