Thread (74 messages) flat view 74 messages, 4 authors, 1d ago

Re: [GSoC PATCH v4 2/7] list-objects-filter: add list_objects_filter__filter_oidset()

From: Siddharth Shrimali <hidden>
Date: 2026-08-12 19:22:56

On Wed, 12 Aug 2026 at 23:34, Junio C Hamano [off-list ref] wrote:
Here "struct object_info" is defined as

        struct object_info {
                /* The object type. */
                enum object_type *typep;

                /* The inflated object size in bytes. */
                size_t *sizep;
                ...

but local "size" whose address is assigned to is of type "unsigned
long".
Oh right, thanks for catching it!
I used "unsigned long" because that is the type the
older object-size interfaces use(odb_read_object()), so I copied that
pattern without noticing that object_info.sizep is "size_t *".

I will change the local to "size_t" in v5 so it matches sizep.

Thanks,
Siddharth Shrimali
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help