Thread (57 messages) flat view 57 messages, 4 authors, 29d ago

Re: [PATCH v6 0/6] packfile URIs: support concurrent downloads

From: Junio C Hamano <hidden>
Date: 2026-08-08 16:23:38

Jeff King [off-list ref] writes:
On Wed, Jul 29, 2026 at 02:41:51PM -0700, Junio C Hamano wrote:
quoted
Ted Nyman [off-list ref] writes:
quoted
Changes since v5:

* Split the existing double-close fix, HTTP 416 handling, generic
  concurrent-download fix, and Windows sharing fix into separate
  patches.
* Replace the FIFO-based concurrent HTTP 416 test with a standalone
  completed-partial test. Besides simplifying the test, this covers the
  non-concurrent interrupted-download case directly.
* Keep the final production code unchanged.

Each patch passes t5550-http-fetch-dumb.sh. The final series also passes
t5702-protocol-v2.sh, and the overlapping-download test passes 240 runs
with 12 parallel stress jobs.

The v5 discussion is at:

https://lore.kernel.org/git/cover.1785047139.git.tnyman@openai.com/ (local)
Is everybody happy with this new iteration?

The design of the re-download feature itself, as far as I
understand, was favourably accepted from the earliest iteration, and
now the CI breakages were corrected with the latest iteration of the
tests, so we should be in pretty good shape, I presume.
Yeah, sorry, I hadn't had time to look carefully. I just did so, and it
all looks good to me. v6 splits the patches in a way that (at least to
my mind) make the trickiest parts of the logic easier to follow.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help