Thread (16 messages) read the whole thread 16 messages, 4 authors, 1d ago
WARM1d

[PATCH 0/2] fix serial tests without/with breaking-changes

From: Jeff King <hidden>
Date: 2026-07-28 14:36:55

On Tue, Jul 28, 2026 at 09:55:32AM -0400, Jeff King wrote:
But we are in a funny limbo now for WITH_BREAKING_CHANGES. Possibly we
could pull the value out of GIT-BUILD-OPTIONS (which I guess happens
already via the environment) and use a prereq to skip the test.
I think we can do even a bit better. Leaving aside
WITH_BREAKING_CHANGES, we should consider what will eventually happen to
these tests when those deprecated commands go away. I think we want to
keep them in preparation for when we have more deprecated commands.

So here's a patch.

It doesn't address the t1517 issue at all. That test can also be
confused by older build products, but I don't think deprecation is
particularly related.  It comes from going to an old version where some
now-vanished command doesn't pass the "-h" test and then traveling back
to the present. Probably it could be more careful about what it
considers a valid command. Right now it checks "git --list-cmds", but in
theory it could be using a list generated from the Makefile.

  [1/2]: t0014: factor out choice of deprecated commands
  [2/2]: t0014: generate deprecated command names dynamically

 t/t0014-alias.sh | 32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help