Thread (23 messages) read the whole thread 23 messages, 5 authors, 4d ago

Re: [PATCH v3] utf8: make utf8_strwidth() and utf8_strnwidth() return size_t

From: Hardik Kumar <hidden>
Date: 2026-07-27 16:20:22

On Mon Jul 27, 2026 at 8:25 PM IST, Junio C Hamano wrote:
Phillip Wood [off-list ref] writes:
quoted
I think it would be much better to remove the TODO comment as Junio 
previously suggested and instead add some documentation to the function 
explaining (a) why it is appropriate for it to return an int; (b) why we 
must use the cast_size_t_to_int() helper to prevent overflows (see the 
commit that added that comment).
Thanks, especially for (b) above.  That needs to be stressed if we
are to go in that direction.
Should this be documented in a new adoc file in the technical
documentation directory?

Thanks,
Hardik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help