Re: [GSoC Patch 7/7] repo: add path.git-prefix path key validation
From: Junio C Hamano <hidden>
Date: 2026-07-16 03:23:20
K Jayatheerth [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/builtin/repo.c b/builtin/repo.c index a97ad71649..00d5064281 100644 --- a/builtin/repo.c +++ b/builtin/repo.c@@ -1,3 +1,4 @@ +#include "compat/posix.h" #define USE_THE_REPOSITORY_VARIABLE #include "builtin.h"
The first include must be <git-compat-util.h> or common include files that include <git-compat-util.h> as the first thing, like <builtin.h>. As the file already includes <builtin.h>, extra inclusion of <compat/posix.h> before everything else is an absolute no-no. By the way, I do not see any "validation" in the patch as the title claims. Perhaps retitle it to "repo: add path.git-prefix key" or something simpler like that?