Re: [PATCH v9 0/4] graph: indent visual roots in graph
From: Mirko Faina <hidden>
Date: 2026-07-12 19:33:16
On Sun, Jul 12, 2026 at 06:59:58PM +0200, Pablo Sabater wrote:
2. Ambiguity:
If it happens that the visual number on visual roots meet the condition
(number_of_visual_roots % 3 == 0) and the next commit is NOT a visual
root this would happen:
A
B
C
D
E
E
Which would be ambiguous. The solution is to check with the lookahead
buffer that we have since patch 3 if the next is a visual root, if it's
not we indent D anyway:
A
B
C
D
E
E
Which I find the pyramid effect uncomfortable.
What about capping at 4 columns?
1.
A
B
C
D
E
F
G
H
2.
A
B
C
D
E
F
F
I prefer the 4 column wrap because it looks more abrupt and IMO shows
better that the commits are unrelated.
What do you think?I agree, warpping beyond three levels instead of two would resolve this ambiguity.
Also, about the no-opt option "--no-graph-indent" is still wanted regardless of the final design that we choose?
Yes, I personally wouldn't want indentation on non-oneline formats. Thank you.