On 7/7/26 12:16 PM, Junio C Hamano wrote:

Aaron Plattner [off-list ref] writes:

quoted

quoted

I wonder if it would make the design more robust and future-proof to
encapsulate this logic in credential.c instead.  For example, we
could introduce a helper function:

      void credential_update_url(struct credential *c, const char *url)

that does what the new code added around credential_from_url() by
this patch does, perhaps?

Yeah, maybe. I'll think about this design some more.

Sorry, I lost track.

Did anything come of that discussion?  No rush, since this change
fixes an immediate issue and the helper suggestion is for long-term
future-proofing.  We can treat them as separate steps.

Thanks.

No, I got sidetracked with other work and didn't get a chance to get 
back to this, sorry. It's not directly impacting my users since I can 
just tell them they have to use my server's FQDN, so fine with me to 
treat this as a low-priority issue.

-- Aaron