Thread (19 messages) 19 messages, 6 authors, 13d ago

Re: [PATCH] meson: wire up USE_NSEC build knob

From: Patrick Steinhardt <hidden>
Date: 2026-07-06 06:43:54

On Fri, Jul 03, 2026 at 11:46:14AM -0400, D. Ben Knoble wrote:
[with apologies for the delay; I wasn't paying attention to "What's
cooking" to notice that this was waiting on my response.]

On Mon, Jun 22, 2026 at 4:13 AM Patrick Steinhardt [off-list ref] wrote:
quoted
On Sun, Jun 21, 2026 at 01:49:34PM -0400, Jeff King wrote:
quoted
But that's all outside the scope of your patch here.
Kind of, I guess. If we figure that this mechanism is still subtly broken
then I'd argue that it doesn't make sense to expose the option via
Meson.
This bit addressed more down-thread, so I'll reply there.

To summarize: If we're all leaning in the direction of a run-time flag
instead, I can noodle in that direction. That certainly involves a bit
more surgery than just giving Meson access to the option, but the
dynamism may be nice. I'm not too sure how we'd write a test case for
it, though.
I don't think we'd necessarily need a way to detect this. Our current
build default is to have this disabled, so I'd keep it this way, but
automatically compile nsec-support into Git if available. And then we
provide a way for users to opt-in to the new behaviour via the config.

An automated test would of course be nice to have so that we know to
enable this in cases where we can determine that it works. But with the
above we'd already make the feature more accessible than it currently
is, because I'd expect that most distros simply don't enable the build
toggle at all.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help