Thread (11 messages) read the whole thread 11 messages, 4 authors, 2026-07-01

Re: [PATCH 2/3] revision: avoid leaking bloom keyvecs with multiple traversals

From: Derrick Stolee <hidden>
Date: 2026-07-01 14:21:36

On 7/1/2026 2:40 AM, Jeff King wrote:
In prepare_revision_walk(), we convert the pruning pathspecs into
bloom-filter "keyvecs" via prepare_to_use_bloom_filter(). This allocates
memory which is then freed eventually by release_revisions(), via
release_revisions_bloom_keyvecs().
 static void prepare_to_use_bloom_filter(struct rev_info *revs)
 {
+	release_revisions_bloom_keyvecs(revs);
+
I continue to support the obviously-correct and simple solution to
these leaks.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help