Thread (3 messages) 3 messages, 3 authors, 11d ago

Re: [PATCH] submodule absorbgitdirs tests: use test_* helper functions

From: Patrick Steinhardt <hidden>
Date: 2026-07-01 08:04:51

On Tue, Jun 30, 2026 at 11:00:28AM -0700, Junio C Hamano wrote:
"Bryan B. Lima" [off-list ref] writes:
quoted
Use modern helper functions from test-lib-functions.sh to provide nice error messages.

Signed-off-by: Bryan B. Lima <redacted>
Co-authored-by: Gustavo S. Correa [off-list ref]
Signed-off-by: Gustavo S. Correa <redacted>
---
 t/t7412-submodule-absorbgitdirs.sh | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
Welcome to the Git development community.
Welcome indeed!
It is rare, but it happens from time to time, that we see a patch by
somebody we haven't seen on this list, and the patch looks perfect.
Very delighted.
Sorry to spoil it: the order of SOBs is incorrect. The patch is authored
by Bryan, so that signoff needs to come last.

The patch itself looks good though, thanks!

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help