Thread (26 messages) 26 messages, 3 authors, 19d ago

Re: [PATCH 5/6] odb: drop `whence` field from object info

From: Justin Tobler <hidden>
Date: 2026-06-29 17:57:40

On 26/06/24 02:19PM, Patrick Steinhardt wrote:
In the preceding commits we have migrated all callers to derive their
information of how a specific object is stored to use the new object
info source instead, and hence the field is now unused. Drop it.
Makes sense.
Signed-off-by: Patrick Steinhardt <redacted>
---
[snip]
quoted hunk ↗ jump to hunk
diff --git a/odb.h b/odb.h
index 330a55879e..e0d05eaf87 100644
--- a/odb.h
+++ b/odb.h
@@ -311,13 +311,6 @@ struct object_info {
 	 * or multiple times in the same source.
 	 */
 	struct object_info_source *sourcep;
-
-	/* Response */
-	enum {
-		OI_CACHED,
-		OI_LOOSE,
-		OI_PACKED,
-	} whence;
 };
Nice. This patch also looks good.

-Justin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help