Thread (42 messages) 42 messages, 5 authors, 3d ago

Re: [PATCH 2/3] t5551: put many-tags case into its own repo

From: Junio C Hamano <hidden>
Date: 2026-06-29 14:42:33

Jeff King [off-list ref] writes:
On Sun, Jun 28, 2026 at 02:44:32PM -0700, Junio C Hamano wrote:
quoted
Jeff King [off-list ref] writes:
quoted
diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
index e236e526f0..cd851f24b8 100755
--- a/t/t5551-http-fetch-smart.sh
+++ b/t/t5551-http-fetch-smart.sh
@@ -397,15 +397,16 @@ create_tags () {
 }
 
 test_expect_success 'create 2,000 tags in the repo' '
+	git init "$HTTPD_DOCUMENT_ROOT_PATH/many-tags.git" &&
 	(
-		cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
+		cd "$HTTPD_DOCUMENT_ROOT_PATH/many-tags.git" &&
 		create_tags 1 2000
 	)
 '
While all the other repositories used in this tests are bare
repositories, this new one is a non-bare repository.

It shouldn't make any difference, but since I noticed it...
Ah, yeah. It should work either way, but it is slightly confusing for it
to be non-bare. I'll wait to re-send (though if nothing else comes up,
it may be simpler for you to just amend on your side).
OK.  It seems both Patrick and you are in favor of using only [1/3]
& [2/3] but dropping [3/3]?  If that is the concensus I can just
tweak this one and apply before 2.55 final.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help