Re: [PATCH] t3420-rebase-autostash: don't try to grep non-existing files

On 27/06/2026 07:59, SZEDER Gábor wrote:

On Sun, Oct 10, 2021 at 07:28:09PM +0200, SZEDER Gábor wrote:

quoted

diff --git a/t/t3420-rebase-autostash.sh b/t/t3420-rebase-autostash.sh
index 43fcb68f27..bbe82d2c0c 100755
--- a/t/t3420-rebase-autostash.sh
+++ b/t/t3420-rebase-autostash.sh

@@ -200,7 +200,7 @@ testrebase () {

With an extra context line we see

		test_path_is_missing file3 &&>>   		git rebase --quit &&

quoted

  		test_when_finished git stash drop &&
  		test_path_is_missing $dotest/autostash &&
-		! grep dirty file3 &&
+		test_path_is_missing file3 &&

and so it is quite clear that this change is correct

Thanks

Phillip

quoted

  		git stash show -p >actual &&
  		test_cmp expect actual &&
  		git reset --hard &&
-- 
2.33.0.1279.g1a260bf8c2

It appears that this patch might have fallen quite deep through the
cracks... ;)

But the issue this patch is addressing is still there, and the patch
still applies cleanly after almost 5 years.