[PATCH 2/2] git-gui: silence statistics under "make -s"
From: Harald Nordgren via GitGitGadget <hidden>
Date: 2026-06-14 17:52:25
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Harald Nordgren <redacted> The catalog rule passed --statistics to msgfmt unconditionally, and its output went to stderr, so it survived "make -s". Pass --statistics only when "-s" is absent, leaving a quiet build silent while default and V=1 builds are unchanged. Signed-off-by: Harald Nordgren <redacted> --- git-gui/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index d33204e875..76245fa84b 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile@@ -90,6 +90,7 @@ ifndef V REMOVE_F0 = dst= REMOVE_F1 = && echo ' ' REMOVE `basename "$$dst"` && $(RM_RF) "$$dst" endif + MSGFMT_STATS = --statistics endif TCLTK_PATH ?= wish
@@ -155,7 +156,7 @@ $(PO_TEMPLATE): $(SCRIPT_SH) $(ALL_LIBFILES) update-po:: $(PO_TEMPLATE) $(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; ) $(ALL_MSGFILES): %.msg : %.po - $(QUIET_MSGFMT0)$(MSGFMT) --statistics --tcl -l $(basename $(notdir $<)) -d $(dir $@) $< $(QUIET_MSGFMT1) + $(QUIET_MSGFMT0)$(MSGFMT) $(MSGFMT_STATS) --tcl -l $(basename $(notdir $<)) -d $(dir $@) $< $(QUIET_MSGFMT1) lib/tclIndex: $(ALL_LIBFILES) generate-tclindex.sh GIT-GUI-BUILD-OPTIONS $(QUIET_INDEX)$(SHELL_PATH) generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS $(ALL_LIBFILES)
--
gitgitgadget